Skip to content

Prevent Y2038 bug by using SSL_SESSION_get_time_ex #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielRuf wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Prevent Y2038 bug by using SSL_SESSION_get_time_ex #607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4982f46
Prevent Y2038 bug by using SSL_SESSION_get_time_ex
DanielRuf Feb 26, 2026
3d65cbf
Implement check for the OpenSSL version
DanielRuf Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/ssl/ssl_engine_kernel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1965,10 +1965,17 @@ int ssl_callback_NewSessionCacheEntry(SSL *ssl, SSL_SESSION *session)
idlen = session->session_id_length;
#endif

#if OPENSSL_VERSION_NUMBER >= 0x30300000
rc = ssl_scache_store(s, id, idlen,
apr_time_from_sec(SSL_SESSION_get_time_ex(session)
+ timeout),
session, conn->pool);
#else
rc = ssl_scache_store(s, id, idlen,
apr_time_from_sec(SSL_SESSION_get_time(session)
+ timeout),
session, conn->pool);
#endif

ssl_session_log(s, "SET", id, idlen,
rc == TRUE ? "OK" : "BAD",
Expand Down