Prevent Y2038 bug by using SSL_SESSION_get_time_ex#607
Open
DanielRuf wants to merge 2 commits intoapache:trunkfrom
Open
Prevent Y2038 bug by using SSL_SESSION_get_time_ex#607DanielRuf wants to merge 2 commits intoapache:trunkfrom
DanielRuf wants to merge 2 commits intoapache:trunkfrom
Conversation
The previous function is deprecated, see: * openssl/openssl@00a6d07 * openssl/openssl#23648 * openssl/openssl#21206
Member
|
Do we need OPENSSL_VERSION_NUMBER-like checks here? |
Author
|
Good question, the function was added in OpenSSL 3.3.0 according to https://github.com/openssl/openssl/blob/master/CHANGES.md#changes-between-32-and-330-9-apr-2024 So I guess yes? |
Collaborator
|
I would inline a |
Author
|
I have added some OpenSSL version check in the latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous function is deprecated, see: