You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot. I understand such modernization is needed (perhaps for other OS than Linux and Windows). However, most current users followed the recommendation to have
in their ~/.bashrc. Udapi does not add new requirements often, so all they have to do for update is git pull.
I understand they should use pip install -e . instead of editing $PATH and $PYTHONPATH. I plan to update the README accordingly. That said, I would like to keep Udapi backward compatible, so I would prefer to (re)create bin/udapy after merging this PR:
#!/usr/bin/env python3
"""Thin wrapper for backward compatibility. Calls udapi.cli.main()."""
import sys
from udapi.cli import main
if __name__ == "__main__":
sys.exit(main())
This bin/udapy will be omitted in new PyPI releases (so that it does not clash with the auto-generated udapy script). @bollwyvl Does this make sense?
Also, I would like to set up GitHub workflow CI tests (instead of the outdated Circle CI) before merging this PRCircle CI to test also PRs from forks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
This PR moves
bin/udapyintoudapi/cli.py, and reworks the naming and structure to work as amainfunction rather than a "pure" script.This is then referenced in
setup.cfgto useconsole_scriptswhich will handle building cross-platform scripts at install time.