Fix Claude startup keychain pre-alert and single prompt flow#311
Closed
ratulsarna wants to merge 4 commits intomainfrom
Closed
Fix Claude startup keychain pre-alert and single prompt flow#311ratulsarna wants to merge 4 commits intomainfrom
ratulsarna wants to merge 4 commits intomainfrom
Conversation
…of "Always Allow" Also show the pre-alert in-app prompt about the keychain access.
Collaborator
Author
|
Closing this PR for now. After end-to-end validation, this branch did not deliver deterministic Claude keychain UX (we still observed repeated startup prompts and inconsistent pre-alert behavior), and it added substantial complexity without a net reliability gain. We have moved back to main and updated keychain documentation to reflect current behavior. We can revisit with a narrower, fresh design if we choose to tackle this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
On some macOS/keychain setups, the first no-UI keychain read can still present the system prompt.
Our previous logic showed the in-app pre-alert only when transitioning to the interactive fallback path, so users could still see a system prompt without any pre-alert.
Changes
Sources/CodexBarCore/Providers/Claude/ClaudeOAuth/ClaudeOAuthCredentials.swiftTests/CodexBarTests/ClaudeOAuthCredentialsStoreTests.swiftValidation
swift testswift test --filter ClaudeOAuthCredentialsStoreTestspnpm check./Scripts/compile_and_run.sh