Skip to content

improvement(luma): expand host response fields and harden event ID inputs#3383

Merged
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/validate-luma
Feb 28, 2026
Merged

improvement(luma): expand host response fields and harden event ID inputs#3383
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/validate-luma

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Expanded host response mapping to include id, firstName, lastName, avatarUrl from Luma API
  • Added .trim() on eventId params to prevent whitespace copy-paste errors
  • Added types barrel export and improved block output descriptions
  • Updated docs to reflect new host fields

Type of Change

  • Enhancement to existing integration

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Building Building Preview, Comment Feb 28, 2026 7:13pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

This PR enhances the Luma integration with two key improvements: expanded host information and input hardening.

Key Changes:

  • Added four new host fields (id, firstName, lastName, avatarUrl) to provide richer host profile data
  • Applied .trim() to all eventId parameters across tools to prevent whitespace-related errors from copy-paste
  • Enhanced output descriptions in block configuration to explicitly list available fields
  • Updated documentation to reflect new host fields and clarify API limitations

Quality:

  • Consistent implementation across all affected tools (get_event, create_event, update_event, add_guests, get_guests)
  • Proper snake_case to camelCase transformation for API response fields
  • Type definitions updated to match new fields
  • Documentation kept in sync with code changes

Confidence Score: 5/5

  • This PR is safe to merge with no issues identified
  • The changes are straightforward enhancements that follow existing patterns consistently. The .trim() additions improve robustness without breaking changes, and the new host fields are properly typed and mapped. All changes maintain backward compatibility since new fields are nullable.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/tools/luma/types.ts Expanded LumaHostEntry interface with id, firstName, lastName, avatarUrl fields and updated output properties constants
apps/sim/tools/luma/get_event.ts Added .trim() to eventId parameter and mapped new host fields from API response
apps/sim/tools/luma/create_event.ts Added mapping for new host fields (id, firstName, lastName, avatarUrl) from snake_case API response to camelCase
apps/sim/tools/luma/update_event.ts Added .trim() to eventId in request body and mapped new host fields
apps/sim/blocks/blocks/luma.ts Enhanced output descriptions to explicitly list all available fields for better clarity

Last reviewed commit: f93b02e

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 647a3eb into staging Feb 28, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/validate-luma branch February 28, 2026 19:19
waleedlatif1 added a commit to abram0v1ch/sim that referenced this pull request Mar 3, 2026
royceP2 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant