gh-145036: Fix data race for list capacity#145365
Open
bkap123 wants to merge 2 commits intopython:mainfrom
Open
gh-145036: Fix data race for list capacity#145365bkap123 wants to merge 2 commits intopython:mainfrom
bkap123 wants to merge 2 commits intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
list___sizeof___implto uselist_capacity()when determining size of a list object in order to prevent a data race.Also, not exactly sure what to do for a test. The current test fails on main only when configured with TSan. Any feedback/suggestions would be greatly appreciated.
list.__sizeof__()with free-threading build #145036