Closed
Conversation
Collaborator
|
As we have discussed in person (comments on issue #62), the ProScan is not a stage, it's a controller device and one of the devices it can control is a stage. I've started implementing such a thing now and can control stage and two filterwheels with it. Closing this without merging. |
carandraug
added a commit
that referenced
this pull request
Nov 26, 2019
…ller. ProScanIII is the concrete class implementing the controller interface for the Prior ProScanII device. For now it can only control filter wheels. There is work in progress to add support for stages but it is dependent on defining a stage interface (issue #99). We don't add support for light sources because we don't have access to them. And don't add support for shutters because there's not even work in progress to add an ABC for them. _ProScanIIIFilterWheel is the concrete class implementing the filter wheel interface. It was tested with a HF108A and a HF110A filter wheel. _ProScanIIIConnection wraps the serial connection and its commands so they can be shared between future classes that add support for other device types. Also handles synchronization of communication from different threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a a StageDevice to devices.py and the priorProScanIII as a concrete implementation of it.