Add a new custom label for close button in dialog header

[bsatarnejad]

What are you trying to accomplish?

Make it possible for close button in dialog header to have a custom label.

Screenshots

Custom aria-label on close button:

Integration

It won't break anything.

List the issues that this change affects.

Closes #3446

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Add a new optional parameter for the header of dialog component named 'close_label' which can be used to pass the value of aria-label of close button in the header of the dialog.

Accessibility

This can improve accessibility since the aria-label has a custom value now.

• Fixes axe scan violation - This change fixes an existing axe scan violation.
• No new axe scan violation - This change does not introduce any new axe scan violations.
• New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: d0a2c9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[francinelucca]

LGTM!

[bsatarnejad]

Hi @francinelucca
Thanks a lot for the review!

I've added and committed the changeset. Regarding the CI errors (Check for changeset and semver label), they seem to be related to the fact that this PR is coming from a forked repository. As a result, the GitHub Actions workflow doesn't have access to the required secrets, which causes those checks to fail. These failures are not related to the actual changes in the PR and can be safely ignored.

Let me know if anything else is needed!

Best regards,
Behrokh

[francinelucca]

merged! thanks for the work on this @bsatarnejad 🙏