chore: run sync-api for 18.9.0 docs#2759
Conversation
| displayTitle: 'C++ addons' | ||
| category: 'api' | ||
| editPage: 'https://github.com/nodejs/node/blob/v18.8.0/doc/api/addons.md' | ||
| editPage: 'https://github.com/nodejs/node/blob/v18.9.0/doc/api/addons.md' |
There was a problem hiding this comment.
Aside, this could probable be guess/calculated at build time to reduce git noise
There was a problem hiding this comment.
Also missing the i18n part of the file path right now
There was a problem hiding this comment.
Also missing the i18n part of the file path right now
WDYM? The source has no i18n. The i18n is done here.
There was a problem hiding this comment.
Aside, this could probable be guess/calculated at build time to reduce git noise
Sure, but this PR is not the right place (IMHO) to talk about this. I'd recommend opening an issue with all your suggestions.
There was a problem hiding this comment.
Oh, I see it's on the node repo. The URL doesn't actually take you to an editable page though, because you can't edit files on a tag path
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
I think I understand the point of this PR now. Let's merge this ASAP as it's just a dry-run
2 participants
Description
Just run
npm run sync-apiand doesn't make any other changesRelated Issues
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.