tls: preserve servername on resumed sessions#62067
Open
jorgitin02 wants to merge 1 commit intonodejs:mainfrom
Open
tls: preserve servername on resumed sessions#62067jorgitin02 wants to merge 1 commit intonodejs:mainfrom
jorgitin02 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
requested changes
Mar 2, 2026
Member
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
This can't land without a single test.
OpenSSL's SSL_get_servername() returns NULL on server-side TLS 1.3 resumed sessions because it reads from ssl->ext.hostname (not populated on resumption) rather than session->ext.hostname (which is persisted). The root cause is that Node.js's SNI callback (SelectSNIContextCallback) returns SSL_TLSEXT_ERR_NOACK when no SNI context switch is needed, which prevents OpenSSL from storing the hostname in the session. Without the hostname in the session, SSL_SESSION_get0_hostname() also returns NULL. Fix this with two minimal changes: 1. In SelectSNIContextCallback, explicitly call SSL_SESSION_set1_hostname() to persist the SNI in the session before ticket serialization. 2. In ncrypto::GetServerName(), fall back to SSL_SESSION_get0_hostname() when SSL_get_servername() returns NULL. Fixes: nodejs#59202 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jorgitin02
force-pushed
the
fix/57175-tls-session-servername
branch
from
a9cecb6 to
5487a28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #57175