Skip to content

doc: separate in-types and out-types in SQLite conversion docs#62034

Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334:doc-sqlite-types-in-out
Open

doc: separate in-types and out-types in SQLite conversion docs#62034
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334:doc-sqlite-types-in-out

Conversation

@Renegade334
Copy link
Member

The API isn't symmetrical here; we should document both.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem. labels Feb 28, 2026
@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2026
| Storage class | JavaScript to SQLite | SQLite to JavaScript |
| ------------- | -------------------------- | ------------------------------------- |
| `NULL` | {null} | {null} |
| `INTEGER` | {number} or {bigint} | {number} or {bigint} _(configurable)_ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `INTEGER` | {number} or {bigint} | {number} or {bigint} _(configurable)_ |
| `INTEGER` | {number} or {BigInt} | {number} or {BigInt} _(configurable)_ |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BigInt is a wrapped BigInt object. bigint is the primitive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! TIL.

Copy link
Contributor

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants