build: do not depend on V8 deps on --without-bundled-v8 builds#62033
Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
Open
build: do not depend on V8 deps on --without-bundled-v8 builds#62033aduh95 wants to merge 1 commit intonodejs:mainfrom
--without-bundled-v8 builds#62033aduh95 wants to merge 1 commit intonodejs:mainfrom
Conversation
aduh95
added
dont-land-on-v20.x
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test-shared on ARM macOS goes from having to compile 328 things down to 213 – that should speed up a bit more the
test-shared.ymlworkflow, and reduce the load on the shared binary cache a bit more (which should help with #61436).AFAICT it's not possible to build Node.js
--without-bundled-v8without providing V8 deps, so this change should not break anything, I've added thedont-land-labels out of precaution.