crypto: do not allow to call setFips from the worker thread#43624
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jul 8, 2022
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
gribnoysup
force-pushed
the
crypto-do-not-allow-set-fips-from-worker-thread
branch
from
2604045 to
caa1862
Compare
gribnoysup
changed the title
gribnoysup
force-pushed
the
crypto-do-not-allow-set-fips-from-worker-thread
branch
from
caa1862 to
f1ea2b8
Compare
addaleax
approved these changes
Jun 30, 2022
addaleax
added
semver-major
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
needs-ci
|
panva
approved these changes
Jun 30, 2022
panva
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43624 ✔ Done loading data for nodejs/node/pull/43624 ----------------------------------- PR info ------------------------------------ Title crypto: do not allow to call setFips from the worker thread (#43624) Author Sergey Petushkov (@gribnoysup) Branch gribnoysup:crypto-do-not-allow-set-fips-from-worker-thread -> nodejs:main Labels crypto, c++, semver-major, author ready, needs-ci Commits 1 - crypto: do not allow to call setFips from the worker thread Committers 1 - Sergey Petushkov PR-URL: https://github.com/nodejs/node/pull/43624 Reviewed-By: Anna Henningsen Reviewed-By: Filip Skokan ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43624 Reviewed-By: Anna Henningsen Reviewed-By: Filip Skokan -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 30 Jun 2022 09:35:43 GMT ✔ Approvals: 2 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/43624#pullrequestreview-1024619683 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/43624#pullrequestreview-1024703643 ✖ semver-major requires at least 2 TSC approvals ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-03T07:53:59Z: https://ci.nodejs.org/job/node-test-pull-request/45063/ - Querying data for job/node-test-pull-request/45063/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2605513821 |
23 tasks
aduh95
approved these changes
Jul 7, 2022
richardlau
approved these changes
Jul 7, 2022
addaleax
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a1653ac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.