fix: remove shell=True from subprocess calls in mcp dev#2190
Open
Br1an67 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: remove shell=True from subprocess calls in mcp dev#2190Br1an67 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Br1an67 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
…ction risk) Remove shell=True from _get_npx_command() and the MCP Inspector subprocess.run() call. On Windows, _get_npx_command() already resolves to the correct .cmd/.exe extension, so shell=True is unnecessary and exposes a command injection risk via shell metacharacters in file paths. Also catch FileNotFoundError in _get_npx_command() for robustness when the command is not found without shell expansion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1257
mcp devusedshell=Truewhen runningnpxon Windows, exposing a command injection risk via shell metacharacters in file paths (e.g.,server&calc.py).Changes
src/mcp/cli/cli.py:shell=Truefrom bothsubprocess.runcalls (_get_npx_commandand the Inspector invocation)._get_npx_command()already resolves tonpx.cmd/npx.exeon Windows, soshell=Trueis unnecessary.FileNotFoundErrorto the exception handler for robustness when the command is not found without shell expansion.Test