fix: include transport path in Protected Resource Metadata resource URL#2189
Open
Br1an67 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: include transport path in Protected Resource Metadata resource URL#2189Br1an67 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Br1an67 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
The resource field in /.well-known/oauth-protected-resource was set to the base resource_server_url (e.g. http://localhost:8000/) instead of the actual protected endpoint URL (e.g. http://localhost:8000/mcp). Per RFC 9728, the resource identifier must match the URL that clients use to access the protected resource. Append the transport path (streamable_http_path or sse_path) to the resource_server_url in both lowlevel/server.py and mcpserver/server.py.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1264
The
resourcefield in/.well-known/oauth-protected-resourcewas set to the baseresource_server_url(e.g.,http://localhost:8000/) instead of the actual protected endpoint URL (e.g.,http://localhost:8000/mcp). Per RFC 9728, the resource identifier must match the URL that clients use to access the protected resource.This caused VS Code Copilot (and other compliant clients) to reject the server with:
Changes
src/mcp/server/lowlevel/server.py: Appendstreamable_http_pathtoresource_server_urlwhen constructing the resource URL for both the protected resource metadata endpoint and the WWW-Authenticate header.src/mcp/server/mcpserver/server.py: Same fix for the SSE transport path.Test