Fix issue #2694#2702
Fix issue #2694#2702debug-ing wants to merge 1 commit intolabstack:masterfrom debug-ing:fix/forwarded-header-2694
Conversation
aldas
left a comment
aldas
left a comment
There was a problem hiding this comment.
Tests are missing.
Are you sure that this implementation is correct? I am looking at https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded#using_the_forwarded_header and the header values are quite complex Forwarded: by=<identifier>;for=<identifier>;host=<host>;proto=<http|https> Where is that proto part parsing is done?
|
This seems so complex that it is maybe worth being separate middleware. Because if you change |
|
That's right, I'll try to fix this problem and make another commit, thanks. |
|
Can I close this pull request and create a new one to fix this issue? |
|
cc: @aldas |
|
Yes, you can close this PR and open another one, but you do not need to. you can add commits on top of this commit. I do not know how much you know Git but things like that are possible. |
|
I know Git and I know it can be done, but I want to do it again. |
2 participants
Fix Fix issue #2694 and add "Forwarded"