Sort tags by date before fetching release notes

[alexcanessa]

GitHub APIs tags returns a list of tags ordered by name (as git tag --list does).

We have to order them per date or the functionality will break.

[wellDan28]

@alexcanessa you can use the github graphql api to get the result ordered by date.

For example:
{ repository(owner: "github-tools", name: "github-release-notes") { refs(refPrefix:"refs/tags/", last:100, orderBy:{field:TAG_COMMIT_DATE, direction: ASC}) { nodes { name } } } }

[wellDan28]

@alexcanessa are you working on this issue?
can I try fixing it?

[alexcanessa]

I've actually started looking into it, but not deeply. You're more than welcome to have a look.

Keep in mind that there is a function that gets the dates of the tags, so far used for other functionality but that could easily be implemented before in the flow and avoid this bug:

github-release-notes/lib/src/Gren.js

Lines 332 to 342 in 3e6b2e4

	_getTagDates(tags) {
	return tags.map(async tag => {
	const { data: { committer } } = await this.repo.getCommit(tag.tag.commit.sha);
	return {
	id: tag.releaseId,
	name: tag.tag.name,
	date: committer.date
	};
	});
	}

[wellDan28]

It's look there is already a function for sorting by dates :

github-release-notes/lib/src/Gren.js

Lines 856 to 858 in 3e6b2e4

	_sortReleasesByDate(releaseDates) {
	return Array.from(releaseDates).sort((release1, release2) => new Date(release2.date) - new Date(release1.date));
	}

I think the real problem is that the paging not working, as I reported in #132
The sorting is working but not on all tags are exists.

[wellDan28]

I think that this issue is less important (after The PR for #132 will be approved)

[alexcanessa]

Fixed in 0.17.1