Add pyramid pattern printing program#14314
Add pyramid pattern printing program#1431424f2002568 wants to merge 4 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| ********* | ||
| """ | ||
|
|
||
| def pyramid(n: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file patterns/pyramid_pattern.py, please provide doctest for the function pyramid
Please provide descriptive name for the parameter: n
There was a problem hiding this comment.
I have added a doctest for the pyramid function and renamed the parameter from n to rows to make it more descriptive. Please review the update. Thank you!
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def pyramid(n: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file patterns/pyramid_pattern.py, please provide doctest for the function pyramid
Please provide descriptive name for the parameter: n
There was a problem hiding this comment.
I have added a doctest for the pyramid function and renamed the parameter from n to rows to make it more descriptive. Please review the update. Thank you!
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def pyramid(n: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file patterns/pyramid_pattern.py, please provide doctest for the function pyramid
Please provide descriptive name for the parameter: n
There was a problem hiding this comment.
I have added a doctest for the pyramid function and renamed the parameter from n to rows to make it more descriptive. Please review the update. Thank you!
2 participants
Describe your change:
This PR adds a beginner-friendly pyramid pattern printing program using Python loops.
Fixes #13462
Type of change
Checklist: