refactor: remove BIP-44 state 1 flag by gantunesr · Pull Request #40468 · MetaMask/metamask-extension

gantunesr · 2026-02-27T00:49:03Z

Description

Remove usage of getIsMultichainAccountsState1Enabled feature flag

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1486

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk refactor primarily removing feature-flagged UI/selector code and unused i18n strings; main behavior change is the account options menu no longer exposes the remove-account action.

Overview
Removes multichain accounts state-1 flag support by deleting the enableMultichainAccounts selector/path and simplifying related UI logic to always use the state-2 behavior.

The account menu/button copy is standardized to addAccountOrWallet, and the account list item menu drops the Remove account menu item (keeping isRemovable only for API compatibility), with tests and locale strings updated to match.

^{Written by Cursor Bugbot for commit dd4640d. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-27T00:49:45Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (4 files, +15 -115)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-list-item-menu/
      - 📄 account-list-item-menu.js +9 -71
      - 📄 account-list-item-menu.test.js +4 -16
    - 📁 account-list-menu/
      - 📄 account-list-menu.test.tsx +1 -1
- 📁 selectors/
  - 📁 multichain-accounts/
    - 📄 feature-flags.ts +1 -27

👨‍🔧 @MetaMask/core-extension-ux (5 files, +22 -126)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-list-item-menu/
      - 📄 account-list-item-menu.js +9 -71
      - 📄 account-list-item-menu.test.js +4 -16
    - 📁 account-list-menu/
      - 📄 account-list-menu.test.tsx +1 -1
    - 📁 account-menu/
      - 📄 account-menu.test.tsx +4 -16
      - 📄 account-menu.tsx +4 -22

metamaskbotv2 · 2026-02-27T01:18:56Z

Builds ready [f7addef]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 391 271 536 106 491 536
total 391 271 536 106 491 536
Confirm Tx confirm_tx 6082 6080 6085 2 6085 6085
total 6082 6080 6085 2 6085 6085
Bridge User Actions bridge_load_page 249 194 279 31 278 279
bridge_load_asset_picker 207 151 285 47 232 285
bridge_search_token 735 706 761 21 751 761
total 1191 1133 1272 50 1220 1272

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1323 1114 1592 106 1355 1563
load 1113 929 1342 90 1141 1303
domContentLoaded 1106 924 1336 89 1135 1295
domInteractive 26 16 130 20 23 77
firstPaint 167 62 1075 114 202 292
backgroundConnect 193 175 416 25 193 214
firstReactRender 19 12 50 5 20 29
initialActions 1 0 5 1 1 3
loadScripts 931 746 1160 90 962 1120
setupStore 12 7 31 5 13 22
numNetworkReqs 31 22 98 21 22 87
Power User Home uiStartup 1750 1462 2116 124 1797 1971
load 1170 1040 1702 138 1158 1563
domContentLoaded 1155 1024 1672 134 1148 1544
domInteractive 38 20 180 26 39 84
firstPaint 188 74 1622 213 214 299
backgroundConnect 294 259 464 28 302 352
firstReactRender 23 14 59 7 26 37
initialActions 1 0 6 1 1 3
loadScripts 943 824 1463 134 929 1331
setupStore 15 7 36 5 17 24
numNetworkReqs 59 39 152 24 57 120

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 217 219 1 219 219
srpButtonToSrpForm 89 87 90 1 89 90
confirmSrpToPwForm 21 21 21 0 21 21
pwFormToMetricsScreen 14 14 15 0 15 15
metricsToWalletReadyScreen 16 13 18 2 17 18
doneButtonToHomeScreen 879 571 1365 372 1301 1365
openAccountMenuToAccountListLoaded 7073 6994 7207 95 7207 7207
total 8283 7825 8953 476 8764 8953
Onboarding New Wallet createWalletToSocialScreen 222 221 223 1 222 223
srpButtonToPwForm 107 106 107 0 107 107
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 37 35 38 1 37 38
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 838 559 1183 266 1134 1183
total 1228 943 1571 267 1526 1571
Asset Details assetClickToPriceChart 53 33 80 19 73 80
total 53 33 80 19 73 80
Solana Asset Details assetClickToPriceChart 48 47 49 1 49 49
total 48 47 49 1 49 49
Import Srp Home loginToHomeScreen 1956 1875 2059 72 2009 2059
openAccountMenuAfterLogin 43 35 53 6 46 53
homeAfterImportWithNewWallet 2150 2008 2327 117 2202 2327
total 4149 3946 4334 141 4272 4334
Send Transactions openSendPageFromHome 28 18 39 9 38 39
selectTokenToSendFormLoaded 18 18 19 0 19 19
reviewTransactionToConfirmationPage 862 857 867 4 866 867
total 905 887 924 13 915 924
Swap openSwapPageFromHome 131 128 133 2 133 133
fetchAndDisplaySwapQuotes 4663 4570 4774 75 4726 4774
total 4795 4721 4907 69 4840 4907

🌐 Dapp Page Load Benchmarks

Current Commit: f7addef | Date: 2/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±44ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 728ms (±43ms) 🟢 | historical mean value: 735ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±13ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	44ms	1.02s	1.39s	1.09s	1.39s
domContentLoaded	728ms	43ms	700ms	1.05s	760ms	1.05s
firstPaint	83ms	13ms	68ms	200ms	92ms	200ms
firstContentfulPaint	83ms	13ms	68ms	200ms	92ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 99 Bytes (0%)
common: -341 Bytes (0%)

sonarqubecloud · 2026-02-27T12:47:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-02-27T13:07:39Z

Builds ready [dd4640d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 271 269 273 2 272 273
total 271 269 273 2 272 273
Confirm Tx confirm_tx 6042 6034 6049 5 6043 6049
total 6042 6034 6049 5 6043 6049
Bridge User Actions bridge_load_page 262 230 289 21 278 289
bridge_load_asset_picker 201 115 351 89 250 351
bridge_search_token 722 703 752 21 744 752
total 1185 1107 1302 83 1267 1302

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1400 1212 1951 112 1432 1593
load 1183 1008 1630 100 1214 1356
domContentLoaded 1175 996 1604 97 1200 1331
domInteractive 28 16 145 20 24 72
firstPaint 162 69 1140 130 205 363
backgroundConnect 207 190 274 13 207 229
firstReactRender 19 12 38 5 20 28
initialActions 1 0 8 1 2 4
loadScripts 985 806 1404 96 1012 1137
setupStore 13 7 35 5 15 22
numNetworkReqs 31 22 88 19 22 83
Power User Home uiStartup 2864 1463 10959 1946 3570 4950
load 1244 1042 1707 139 1290 1583
domContentLoaded 1224 1035 1681 133 1264 1553
domInteractive 37 18 195 26 36 93
firstPaint 200 92 457 90 280 353
backgroundConnect 1020 269 8793 1560 1055 2716
firstReactRender 26 16 54 7 28 39
initialActions 1 0 8 1 1 3
loadScripts 1010 827 1457 129 1041 1337
setupStore 16 5 50 8 18 29
numNetworkReqs 78 44 141 22 89 119

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 217 222 2 221 222
srpButtonToSrpForm 94 93 95 1 95 95
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 16 16 17 0 16 17
doneButtonToHomeScreen 818 590 1136 191 891 1136
openAccountMenuToAccountListLoaded 7452 6859 7829 358 7687 7829
total 8825 8731 8943 78 8842 8943
Onboarding New Wallet createWalletToSocialScreen 222 220 224 2 223 224
srpButtonToPwForm 107 100 112 5 111 112
createPwToRecoveryScreen 8 8 9 0 9 9
skipBackupToMetricsScreen 35 34 37 1 36 37
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 812 558 1190 278 1111 1190
total 1204 939 1593 282 1501 1593
Asset Details assetClickToPriceChart 39 38 40 1 40 40
total 39 38 40 1 40 40
Solana Asset Details assetClickToPriceChart 59 58 59 0 59 59
total 59 58 59 0 59 59
Import Srp Home loginToHomeScreen 2010 1912 2192 104 2053 2192
openAccountMenuAfterLogin 47 47 48 0 47 48
homeAfterImportWithNewWallet 2360 2146 2715 205 2402 2715
total 4417 4124 4815 261 4605 4815
Send Transactions openSendPageFromHome 19 17 21 1 19 21
selectTokenToSendFormLoaded 20 18 22 1 19 22
reviewTransactionToConfirmationPage 861 855 865 4 864 865
total 906 893 921 10 911 921
Swap openSwapPageFromHome 115 113 120 3 120 120
fetchAndDisplaySwapQuotes 4702 4615 4817 81 4738 4817
total 4821 4728 4916 80 4883 4916

🌐 Dapp Page Load Benchmarks

Current Commit: dd4640d | Date: 2/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±47ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 728ms (±43ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	47ms	1.01s	1.36s	1.05s	1.36s
domContentLoaded	728ms	43ms	708ms	1.03s	738ms	1.03s
firstPaint	79ms	10ms	60ms	160ms	88ms	160ms
firstContentfulPaint	79ms	10ms	60ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: -136 Bytes (0%)
ui: 99 Bytes (0%)
common: -123 Bytes (0%)

refactor: remove BIP-44 state 1 flag

f7addef

gantunesr temporarily deployed to pr-comment February 27, 2026 00:49 — with GitHub Actions Inactive

metamaskbot added the team-accounts-framework Accounts team label Feb 27, 2026

github-actions bot added the size-M label Feb 27, 2026

gantunesr temporarily deployed to pr-comment February 27, 2026 01:14 — with GitHub Actions Inactive

fix: test

dd4640d

gantunesr temporarily deployed to pr-comment February 27, 2026 12:34 — with GitHub Actions Inactive

gantunesr mentioned this pull request Feb 27, 2026

refactor: remove BIP-44 state 1 flag #40385

Closed

7 tasks

gantunesr temporarily deployed to pr-comment February 27, 2026 13:03 — with GitHub Actions Inactive

gantunesr marked this pull request as ready for review February 27, 2026 13:09

gantunesr requested review from a team as code owners February 27, 2026 13:09

gantunesr temporarily deployed to pr-comment February 27, 2026 13:09 — with GitHub Actions Inactive

gantunesr added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Feb 27, 2026

n3ps approved these changes Feb 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove BIP-44 state 1 flag#40468

refactor: remove BIP-44 state 1 flag#40468
gantunesr wants to merge 2 commits intomainfrom
gar/refactor/bip44/state1

gantunesr commented Feb 27, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gantunesr commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Feb 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gantunesr commented Feb 27, 2026 •

edited

Loading

metamaskbotv2 bot commented Feb 27, 2026 •

edited

Loading