Add completeBrackets flag to Behavior configuration#366
Open
cavoco wants to merge 1 commit intoCodeEditApp:mainfrom
Open
Add completeBrackets flag to Behavior configuration#366cavoco wants to merge 1 commit intoCodeEditApp:mainfrom
cavoco wants to merge 1 commit intoCodeEditApp:mainfrom
Conversation
Add a completeBrackets property to SourceEditorConfiguration.Behavior that controls whether bracket pair completion filters are registered. When false, open-pair and delete-pair filters are skipped in setUpTextFormation(), allowing consumers to disable automatic bracket completion via configuration. Fixes CodeEditApp/CodeEdit#1691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completeBrackets: Boolproperty toSourceEditorConfiguration.Behavior(defaults totrue)false,setUpTextFormation()skips registeringStandardOpenPairFilterandDeleteCloseFilter, disabling automatic bracket completionsetUpTextFormation()to rebuild the filter listContext
This is needed to fix CodeEdit#1691 — the "Autocomplete Braces" setting in CodeEdit's text editing preferences exists in the UI but has no effect because there was no way to pass it through to the source editor configuration.
Once this is merged, the CodeEdit side just needs to wire
autocompleteBracesinto thebehaviorconfig inCodeFileView.swift.Test plan
test_completeBracketsEnabled— verifies pair filters are present when enabledtest_completeBracketsDisabled— verifies pair filters are absent when disabledTextViewControllerTestspass with no regressions