Introduce private comments when reviewing pull requests #177786
Replies: 4 comments 1 reply
-
Write comments but don't submit them
Use a separate tool (Notion, Obsidian, text file)
Some extensions add private annotations to GitHub
GitHub saves draft comments temporarily Why This Feature Makes Sense Keep a local markdown file per PR: PR-1234-notes.md Bottom line: Valid feature request, no perfect workaround exists yet. External notes are your best bet for now. |
Beta Was this translation helpful? Give feedback.
-
|
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
-
|
Hey! I totally feel you on the 'PR noise' vs 'mental context' struggle. I looked into it, and while GitHub doesn't have a 'Private Comment' button yet, there are three 'pro' ways to handle this: |
Beta Was this translation helpful? Give feedback.
-
|
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
General
Body
When I review pull requests, I often make notes in form of review comments. I write down why something makes sense, why something is not necessary, etc.
Sometimes I end up posting them as part of my review: they might be useful to other reviewers and also serve me again if I re-review the changes after some time. This way, I don't need to remember the whole context or go through the same mental effort each time I look at it. However, most of the time, I remove them before submitting my feedback because I don't think others will benefit from them, so all it would do is produce unnecessary noise.
I think it would be nice if GitHub offered a feature allowing to create private comments that would only be visible to you. This way, I would keep all the advantages of having the notes, while avoiding sharing feedback of questionable value.
In my opinion, many people would benefit from this.
Beta Was this translation helpful? Give feedback.
All reactions